Skip to content

Fixed a bug when processing data without socre columns.#2

Open
miyamamoto wants to merge 2 commits into
fullflu:masterfrom
miyamamoto:master
Open

Fixed a bug when processing data without socre columns.#2
miyamamoto wants to merge 2 commits into
fullflu:masterfrom
miyamamoto:master

Conversation

@miyamamoto
Copy link
Copy Markdown
Contributor

No description provided.

@fullflu
Copy link
Copy Markdown
Owner

fullflu commented Nov 24, 2016

Hi @miyamamoto thank you for submitting this pull request.

I understand a bug when processing data without score columns, but I guess there are still some bugs of the scripts.

  • First, line 70 of listnet.py
self.T = len(self.X)

may be

self.test_T = len(self.test_X)
  • Second, line 4 of getsampledata.sh
unrar MQ2008.rar

may be

unrar x MQ2008.rar

I'd like to hear your opinion.

@miyamamoto
Copy link
Copy Markdown
Contributor Author

miyamamoto commented Dec 9, 2016

Thank you very much.
Certainly, I think that the above correction is necessary. I will correct it and send a pull request again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants