docs(#832): prohibit unsubstantiated verification claims in review output - #835
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#832): prohibit unsubstantiated verification claims in review output#835fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
…tput Add explicit prohibition in the pr-review SKILL.md output format section against freeform verification sections that claim properties verified beyond what static diff analysis can confirm. The review agent cannot verify reference integrity, credential flows, or runtime behavior — those require CI/runtime validation. Prior findings no longer present should use "not observed in current diff" rather than "verified resolved." Expand the challenger sub-agent procedure to challenge verification claims in aggregated output, not just findings. The challenger now removes unsubstantiated verification text (e.g., "all references verified", "delivery chain confirmed", "zero X remain"). Closes #832
|
🤖 Finished Review · ✅ Success · Started 12:42 PM UTC · Completed 12:56 PM UTC Commit: |
ReviewFindingsMedium
Labels: PR modifies review agent skill files under skills/pr-review/ |
fullsend-ai-review
Bot
added
requires-manual-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
During the 13+ review iterations on PR #211, the review bot produced freeform text asserting "zero references to deleted files remain" and "GH_TOKEN delivery chain verified" at commits where both were provably false. The prescribed output format does not include a "Verified" section, and the challenger sub-agent was not scoped to challenge such claims.
Test plan
hack/lint-agent-docs-test.shpassesmake check-bundlepasses (no script changes)Closes #832
Post-script verification
agent/832-prohibit-unsubstantiated-verification)1a3086f5512b3700ab8e081c689cc7586c9af20f..HEAD)