Skip to content

docs(#6113): surface org-mode deprecation in agent-visible files - #6114

Merged
waynesun09 merged 2 commits into
mainfrom
agent/6113-surface-org-mode-deprecation
Aug 19, 2026
Merged

docs(#6113): surface org-mode deprecation in agent-visible files#6114
waynesun09 merged 2 commits into
mainfrom
agent/6113-surface-org-mode-deprecation

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Surfaces the per-org installation mode deprecation (ADR 0044) in files that agents routinely read, so they avoid generating or engaging with org-mode content as active architecture.

Related Issue

Changes

  • AGENTS.md: Added a bullet to "How to work in this repo" noting that per-org mode is deprecated per ADR 0044 and instructing agents not to add org-mode-specific content
  • docs/agents/triage.md: Annotated the org-mode reference (line 73) with an inline deprecation note and link to the ADR

Testing

  • Verified AGENTS.md now contains org-mode deprecation notice (grep -q 'ADR.0044' AGENTS.md)
  • Verified triage.md org-mode reference is annotated with deprecation (grep -n 'org.mode' docs/agents/triage.md | grep -qi 'deprecated')
  • Secret scan passed
  • gitlint passed

Note: make lint could not run in-sandbox (network policy blocks pre-commit hook environment setup). The post-script runs pre-commit authoritatively on the runner.

Checklist

  • PR title follows Conventional Commits (correct type, ! for breaking changes)
  • No secrets or sensitive data in the diff

Closes #6113

Post-script verification

  • Branch is not main/master (agent/6113-surface-org-mode-deprecation)
  • Secret scan passed (gitleaks — 65ceb961020290e43b008daa380765b44f35c5df..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner August 11, 2026 18:53
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Agent PR ready for human review label Aug 11, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 11, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:54 PM UTC · Completed 7:06 PM UTC

Commit: 9d885b0 · View workflow run →

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

Site preview

Preview: https://727d31e6-site.fullsend-ai.workers.dev

Commit: 932a6760a2ea35c2e8de55f476ce61b9720cfbf4

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review

Findings

Medium

Low

Previous run

Review

Findings

Medium

  • [protected-path] AGENTS.md:20 — AGENTS.md is a protected governance file. This PR modifies it to add a deprecation notice for per-org installation mode, with linked issue Surface org-mode deprecation in agent-visible context files #6113 and ADR 0044 providing clear rationale. Human approval is always required for protected-path changes, regardless of context.

Low

  • [readability] docs/agents/triage.md:73 — The deprecation annotation breaks mid-parenthetical across lines 73-74 in the raw markdown source. However, rendered markdown treats this as a single continuous line — the line break is invisible to readers. Optionally reflow to keep the parenthetical on one line for source readability.

Labels: PR modifies documentation files (AGENTS.md, docs/agents/triage.md) to surface org-mode deprecation.

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment component/docs User-facing documentation labels Aug 11, 2026
@waynesun09 waynesun09 self-assigned this Aug 19, 2026
AGENTS.md had no mention of the per-org installation mode deprecation
(ADR 0044), so agents generated and reviewed org-mode content as if
it were active architecture. Add a bullet to the "How to work in this
repo" section instructing agents not to add org-mode-specific content
and to flag existing org-mode references as deprecated.

Also annotate the org-mode reference in docs/agents/triage.md (line 73)
with an inline deprecation note and link to ADR 0044, so the triage
agent documentation reflects the current state.

Note: pre-commit could not run in-sandbox (network policy blocks git
fetch for hook environment setup). The post-script runs pre-commit
authoritatively on the runner.

Closes #6113
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 19, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:33 PM UTC · Completed 6:50 PM UTC

Commit: 1233235 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
Comment thread docs/agents/triage.md Outdated
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 19, 2026

Copy link
Copy Markdown

🤖 Review · ⚠️ Cancelled · Started 7:19 PM UTC · Ended 7:24 PM UTC

Commit: 061b455 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 19, 2026

Copy link
Copy Markdown

🤖 Review · ⚠️ Cancelled · Started 7:26 PM UTC · Ended 7:28 PM UTC

Commit: 9ec3091 · View workflow run →

The original bullet said per-org mode is deprecated but didn't call
out that the rule applies to human contributors as well as agents.
waynesun09 noted on #6113 that the generic phrasing already failed to
prevent recurrence on PR #6375, so make the instruction explicit:
don't add or extend org-mode-specific content, and flag it as
deprecated rather than active architecture when reviewing.

Deliberately don't link a specific tracking issue for the command
removal inventory: #2302 (originally linked) closed and split into
#6390-#6392, and #6391 (the deprecation-warning issue that enumerated
the commands) closed as not-planned when the team decided to remove
per-org support directly instead of warning first. Issue state churns
too fast for a rule file to track — the ADR link is stable and durable
in a way a specific issue number is not, so point only to ADR 0044 and
let it be the single source of truth for removal scope.

Apply the same clarification to the docs/agents/triage.md annotation
so it reads consistently with AGENTS.md.

Signed-off-by: Wayne Sun <gsun@redhat.com>

Assisted-by: Claude
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 19, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:30 PM UTC · Completed 7:46 PM UTC

Commit: 932a676 · View workflow run →

@waynesun09 waynesun09 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and rebased the deprecation-scoping fixes discussed on #6113 — content addresses the recurrence on PR #6375, drops the stale #2302/#6391 issue references in favor of the stable ADR 0044 link, and CI is green.

@waynesun09
waynesun09 added this pull request to the merge queue Aug 19, 2026
Merged via the queue into main with commit 0f28119 Aug 19, 2026
16 checks passed
@waynesun09
waynesun09 deleted the agent/6113-surface-org-mode-deprecation branch August 19, 2026 19:39
@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 19, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ❌ Failure · Started 7:42 PM UTC · Completed 7:43 PM UTC

Commit: 932a676 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open PRs/MRs.

Posted by fullsend post-review check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/docs User-facing documentation ready-for-review Agent PR ready for human review requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Surface org-mode deprecation in agent-visible context files

1 participant