-
Notifications
You must be signed in to change notification settings - Fork 88
feat(workflows): extract harness-run into reusable workflow #6356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+334
−170
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e40ec82
feat(workflows): extract harness-run into reusable workflow
ralphbean f060999
test(scaffold): update tests for harness-run extraction
ralphbean 020c495
feat(workflows): add optional JIRA secrets to reusable workflows
ralphbean 5bfa837
fix(#6356): propagate workflow context to reusable-harness-run
ralphbean 5f34449
fix(#6356): address review feedback
ralphbean 7a08e38
fix(#6356): use github context instead of job context in reusable wor…
ralphbean 9393f44
fix(#6356): address PR review feedback on reusable-harness-run
ralphbean c5c24db
fix(#6356): remove workflow_sha input to reusable-harness-run
ralphbean 698589c
fix(#6356): remove workflow_repository input, use job.workflow_reposi…
ralphbean cc0486c
fix(#6356): allow hyphens in reusable workflow ref regex
fullsend-ai-coder[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[low] scope-creep
Adding JIRA_TOKEN and JIRA_USER_EMAIL secrets to the workflow_call interface extends beyond the strict scope of issue #6347 (extract harness-run), though the threading is a natural dependency of making the extracted workflow functional for Jira-integrated agents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know.. but, let it go please. It is the work that is driving this improvement.