refactor: reduce cyclomatic complexity across multiple modules#1188
Merged
Conversation
added 3 commits
January 26, 2026 01:52
- Extract helper methods in UserService.Lifecycle.cs - Simplify SearchUsersQueryHandler with extracted methods - Fixes CA1827 warnings (Count vs Any)
- AssignRolesAsync: 19 → extracted ValidateAdminRoleChangeAsync, ProcessRoleAssignmentsAsync - GetOrCreateFromPrincipalAsync: 18 → extracted claim handling, user creation helpers - RegisterAsync: 13 → extracted password validation, email sending, shared helpers Average complexity: 4.7 → 3.5 High complexity methods: 3 → 0
## Changes ### TenantThemeState.cs & ThemeStateFactory.cs - MapFromDto: 52 → 6 (extracted MapLightPalette, MapDarkPalette, etc.) ### TokenRefreshService.cs - TryRefreshTokenAsync: 39 → 8 (extracted cache checks, token validation, claims building) ### AuditHttpMiddleware.cs - InvokeAsync: 30 → 6 (extracted request/response capture, audit writing) ### EntityDiffBuilder.cs - Build: 25 → 5 (extracted property change detection, operation determination) ### SmtpMailService.cs - SendAsync: 19 → 4 (extracted sender/recipient config, attachments) ### IdentityService.cs - ValidateCredentialsAsync: 14 → 5 - ValidateRefreshTokenAsync: 14 → 5 - Eliminated duplicated claims building logic ## Impact - Eliminated 6 'Very Complex' and 'Untestable' rated methods - All refactored methods now ≤10 complexity - Better testability and maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major complexity reduction across 7 files, eliminating all 'Very Complex' and 'Untestable' rated methods.
Changes
Techniques Used
Build Status
✅ 0 warnings, 0 errors