feat(cli): implement upgrade check (Sprint 2) #1196
Merged
Annotations
10 warnings
|
src/Tools/CLI/Services/VersionComparer.cs#L140
'string.IndexOf(char)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'FSH.CLI.Services.VersionComparer.ParseVersionParts(string)' with a call to 'string.IndexOf(char, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
src/Tools/CLI/Commands/VersionCommand.cs#L123
Avoid creating a new 'JsonSerializerOptions' instance for every serialization operation. Cache and reuse instances instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1869)
|
|
src/Tools/CLI/Commands/UpgradeCommand.cs#L120
Do not use Enumerable methods on indexable collections. Instead use the collection directly. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1826)
|
|
src/Tools/CLI/Services/VersionComparer.cs#L118
Remove this unused method parameter 'package'. (https://rules.sonarsource.com/csharp/RSPEC-1172)
|
|
src/Tools/CLI/Services/VersionComparer.cs#L126
Merge this if statement with the enclosing one. (https://rules.sonarsource.com/csharp/RSPEC-1066)
|
|
src/Tools/CLI/Commands/UpgradeCommand.cs#L256
Remove this unused method parameter 'cancellationToken'. (https://rules.sonarsource.com/csharp/RSPEC-1172)
|
|
src/Tools/CLI/Commands/UpgradeCommand.cs#L256
Remove this unused method parameter 'manifest'. (https://rules.sonarsource.com/csharp/RSPEC-1172)
|
|
src/Tools/CLI/Services/VersionComparer.cs#L34
Modify 'ParsePackagesProps' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
src/Tools/CLI/Models/FshManifest.cs#L79
Modify 'TryLoad' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
src/Tools/CLI/Commands/UpgradeCommand.cs#L258
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
|
The logs for this run have expired and are no longer available.
Loading