fix(auditing): add missing base.OnModelCreating() call in AuditDbContext#1228
Merged
Conversation
Without the base call, Finbuckle's MultiTenantDbContext.OnModelCreating() was never invoked, which means the .IsMultiTenant() configuration on AuditRecord was not activated into actual query filters — risking cross-tenant data leakage for audit records. Closes #1226 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base.OnModelCreating(modelBuilder)call inAuditDbContext, ensuring Finbuckle's multi-tenant query filters are properly activated for audit records..IsMultiTenant()configuration onAuditRecordwas never converted into actual EF Core query filters, risking cross-tenant data leakage.IdentityDbContextandTenantDbContext.Closes #1226
Test plan
dotnet build src/FSH.Framework.slnxsucceedsdotnet test src/FSH.Framework.slnxpasses🤖 Generated with Claude Code