Skip to content

Add URL tracking parameter stripping for clipboard - #1833

Open
ftlframe wants to merge 2 commits into
futo-org:masterfrom
ftlframe:feature/strip-url-tracking-params
Open

Add URL tracking parameter stripping for clipboard#1833
ftlframe wants to merge 2 commits into
futo-org:masterfrom
ftlframe:feature/strip-url-tracking-params

Conversation

@ftlframe

Copy link
Copy Markdown

Closes #556 - automatically removes tracking parameters
(utm_*, fbclid, si, etc.) from URLs copied to the clipboard using the ClearURLs ruleset.

  • Add UrlCleaner.kt utility that parses url-rules.json and strips tracking params
  • Add ClipboardStripUrlTracking setting (disabled by default)
  • Modify ClipboardHistoryManager to clean URLs when copied
  • Modify QuickClip to display cleaned URLs in suggestion bar
  • Add url-rules.json from ClearURLs project to assets

Testing:

  • "Remove URL tracking parameters" in Clipboard settings
  • URLs with tracking params (YouTube, Amazon, etc.)
  • Verify tracking params are stripped when pasted

   Implements GitHub issue futo-org#556 - automatically removes tracking parameters
   (utm_*, fbclid, si, etc.) from URLs copied to the clipboard using the ClearURLs ruleset.
   - Add UrlCleaner.kt utility that parses url-rules.json and strips tracking params
   - Add ClipboardStripUrlTracking setting (disabled by default)
   - Modify ClipboardHistoryManager to clean URLs when copied
   - Modify QuickClip to display cleaned URLs in suggestion bar
   - Add url-rules.json from ClearURLs project to assets
@futo-cla-pr-labler

Copy link
Copy Markdown

Please sign our contributor license agreement at https://cla.futo.org

1 similar comment
@futo-cla-pr-labler

Copy link
Copy Markdown

Please sign our contributor license agreement at https://cla.futo.org

@abb128 abb128 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I haven't tested the changes yet but a couple things stood out to me in the code

Comment thread java/src/org/futo/inputmethod/latin/uix/actions/ClipboardHistoryAction.kt Outdated
Comment thread java/src/org/futo/inputmethod/latin/uix/UrlCleaner.kt Outdated
@SamCyanide

Copy link
Copy Markdown

Would love to see this implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA-signed Enhancement Request for a new feature Privacy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Tracking Parameters from URLs

4 participants