feat(TS): add types so that rules can be used in TS eslint.config files #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f5e71b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Is it enough to update changelog, or changeset bot requires other things to set up? |
ota-meshi
requested changes
May 21, 2025
This reverts commit 4e45430.
ota-meshi
requested changes
May 21, 2025
tsconfig.build.json
Outdated
| @@ -2,6 +2,7 @@ | |||
| "extends": "./tsconfig.json", | |||
| "exclude": ["tests/**/*", "tools/**/*"], | |||
| "compilerOptions": { | |||
| "removeComments": true /* Do not emit comments to output. */ | |||
| "removeComments": true, /* Do not emit comments to output. */ | |||
There was a problem hiding this comment.
Could you fix the formatting issue?
There was a problem hiding this comment.
let me try from linux
ota-meshi
reviewed
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to use the plugin to eslint our vue files, but as we are in full TS environment, our eslint.config.ts file need typings for all plugins and this is preventing us to use it.
The project is already using Typescript even for building, it's a pity that type definitions are not published.
Can it be enhanced with these changes, so that types can be available?
I've tested the builded package and it is working fine with our TS configurations, another look at it would be nice.
Thanks in advance.