Closed
Clarify CI submodule security: explain why .gitmodules edits bypass pull_request workflow isolation#2481
.gitmodules edits bypass pull_request workflow isolation#2481Conversation
8 tasks
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on removing fanal framework and Trivy parser usage
Clarify CI submodule security: explain why Mar 23, 2026
.gitmodules edits bypass pull_request workflow isolation
Collaborator
|
Thanks, |
!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a review question about whether the git submodule attack vector is theoretically distinct from an attacker simply editing the workflow file directly.
Key distinction:
pull_requestevents run the workflow from the base branch — direct edits to.github/workflows/test.ymlin a fork are ignored by GitHub's event isolationactions/checkoutwithsubmodules: truereads.gitmodulesfrom the checked-out merge commit (i.e., the fork's code) — a modified submodule URL bypasses the workflow file protection entirely and causes attacker-controlled code to be cloned and executedThe comment in
analyze_golden_test.goand the decision to omitsubmodules: truefrom CI are intentional and correct; this PR adds a reply clarifying the mechanism that makes the two cases non-equivalent.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.