Skip to content
This repository was archived by the owner on Apr 1, 2023. It is now read-only.
This repository was archived by the owner on Apr 1, 2023. It is now read-only.

Remove cached clock (need to measure performance metrics first) #337

Description

@ccjeff

Detail Description:
The original CachedClock achieves fast ticking by simply increasing the timestamp by 1 unit of time when now() is called. When precise time comparison is needed, we need to set refresh to true to get the time from std::chrono::steady_clock. This is causing issue in the 3SITxnTest. When it is calling the doRead, if there is a conflict, it will be resolved using the push operation (K23SIPartitionModule::_doPush) in Module.cpp. This is taking in a fast deadline as a parameter. If not synced properly, this deadline will be way behind the actual time and causing other deadlines to break.

We need to measure the performance impact of the CachedClock against steady_clock. If there is no significant impact, we should remove the CachedClock.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions