Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
sdistrelease; Currently, thetar.gzdo not contain all the necessary build files (C, cmake, etc) and it is not possible to install through pypi from source. Adding theMANIFEST.inwill fix that.I had a minute and just went ahead and looked into this. It seems you need a
MANIFEST.in. I modeled one, mostly based on your.gitignore(for excludes) and included thesrc,external,cmakeandtestsdirectories. It also keeps the release tar.gz quite small at ~350kB. I think this works, running the build right now to make sure of it.Closes #92