Skip to content

Allow validation errors on entries without interaction #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 16, 2025

Conversation

kruitbosdotdev
Copy link

Description:

Implements a way to show errors without user interaction as described in the issue mentioned below. The main goal was to implement this change without modifying existing tests, ensuring that current behavior remains intact. The default functionality continues to work as expected without setting AlwaysShowValidationError.

All the tests create their testbed from the ground up instead of expanding a single test and doing SetText() for example. This way the tests test the behaviour when the entry is rendered instead of relying on user interaction to tigger a Refresh().

Fixes #5590

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.

@andydotxyz
Copy link
Member

Thanks for this, unfortunately it came in after the feature freeze and we are now in full release mode.
This should be good to go after that, but will need a "Since: 2.7" line instead.

@kruitbosdotdev
Copy link
Author

Will do. I'll also take a look at the failing tests

@coveralls
Copy link

Coverage Status

coverage: 62.241% (-0.06%) from 62.299%
when pulling c89a5a1 on kruitbosdotdev:implementation-5590
into b252798 on fyne-io:develop.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this worked out - let's land it and get 2.7 work started :)

@andydotxyz andydotxyz merged commit ea5a905 into fyne-io:develop Apr 16, 2025
11 checks passed
@kruitbosdotdev kruitbosdotdev deleted the implementation-5590 branch April 16, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants