Skip to content

Don't manage content visibility at window level #5624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

Don't manage content visibility at window level #5624

merged 1 commit into from
Jul 4, 2025

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Mar 25, 2025 •
edited
Loading

Fixes requested feature to have window visible with hidden top level content.

Fixes #5597

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Don't manage content visibility at window level
09cd728 
This is required to support the requested "hidden window content".
@coveralls
Copy link

Coverage Status

coverage: 51.171% (-11.1%) from 62.261%
when pulling 09cd728 on andydotxyz:fix/windowhiddencontent
into 88b597e on fyne-io:develop.

@andydotxyz
Copy link
Member Author

See #5597

sdassow
sdassow approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@sdassow sdassow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less side-effects are good in my experience, and widgets aren't hidden by default anyways, so this makes sense to me.

@andydotxyz andydotxyz marked this pull request as ready for review July 4, 2025 13:38
@andydotxyz andydotxyz merged commit ede4e64 into fyne-io:develop Jul 4, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdassow sdassow sdassow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @sdassow