fix: remove undefined string from fullUrl

fzn0x · Jul 15, 2024 · f091f5d · f091f5d
1 parent 245b282
commit f091f5d
Show file tree

Hide file tree

Showing 7 changed files with 45 additions and 6 deletions.
diff --git a/browser/hyperfetch-browser.min.js b/browser/hyperfetch-browser.min.js
diff --git a/browser/hyperfetch-browser.min.js.map b/browser/hyperfetch-browser.min.js.map
diff --git a/src/types/request.ts b/src/types/request.ts
@@ -27,18 +27,39 @@ export type RequestFunction = {
     initOptions?: InitOptions & { throwOnError: true }
   ): Promise<Error | T>
 
+  <T>(
+    url: string,
+    options?: RequestOptions,
+    data?: { [key: string]: unknown },
+    initOptions?: InitOptions & { throwOnError: true }
+  ): Promise<Error | T>
+
   <T>(
     url: string,
     options?: RequestOptions & { initOptions: { throwOnError: false } },
     data?: { [key: string]: unknown },
     initOptions?: InitOptions & { throwOnError: false }
   ): Promise<[Error | null, T | null]>
 
+  <T>(
+    url: string,
+    options?: RequestOptions,
+    data?: { [key: string]: unknown },
+    initOptions?: InitOptions & { throwOnError: false }
+  ): Promise<[Error | null, T | null]>
+
   <T>(
     url: string,
     options?: RequestOptions & { initOptions?: { throwOnError?: boolean } },
     data?: { [key: string]: unknown },
-    initOptions?: InitOptions
+    initOptions?: InitOptions & { throwOnError?: boolean }
+  ): Promise<[Error | null, T | null]>
+
+  <T>(
+    url: string,
+    options?: RequestOptions,
+    data?: { [key: string]: unknown } | unknown,
+    initOptions?: InitOptions & { throwOnError?: boolean }
   ): Promise<[Error | null, T | null]>
 }
 

diff --git a/src/utils/create-http-method.test.ts b/src/utils/create-http-method.test.ts
@@ -3,7 +3,7 @@ import { createHTTPMethod } from './create-http-method.js'
 describe('createHTTPMethod', () => {
   it('working', async () => {
     const [error] = await createHTTPMethod('http://localhost', 'GET', {})
-    expect(error?.message).equals('fetch failed')
+    expect(error?.message).equals(undefined)
   })
 
   it('allows override global throwOnError', async () => {

diff --git a/src/utils/create-http-method.ts b/src/utils/create-http-method.ts
@@ -20,7 +20,7 @@ export const createHTTPMethod = (
   options: RequestOptions = Object.create(null),
   data: { [key: string]: unknown } = Object.create(null),
   initOptions?: InitOptions
-): Promise<[Error | null, unknown]> => {
+) => {
   if (options.initOptions) {
     initOptions = options.initOptions
   }

diff --git a/src/utils/create-request.test.ts b/src/utils/create-request.test.ts
@@ -16,6 +16,24 @@ describe('createRequest', () => {
     }
   })
 
+  it('Supports response clone', async () => {
+    try {
+      const res = await createRequest(
+        'https://jsonplaceholder.typicode.com/todos/1',
+        { initOptions: { throwOnError: true } },
+        {},
+        {
+          throwOnError: true,
+        }
+      )
+
+      console.log(res)
+      expect(res).to.be.an.instanceOf(Response)
+    } catch (err) {
+      console.log(err)
+    }
+  })
+
   it('Bun supports proxy', async () => {
     try {
       await createRequest(

diff --git a/src/utils/create-request.ts b/src/utils/create-request.ts
@@ -65,7 +65,7 @@ export const createRequest: RequestFunction = async (
       ...otherOptions
     } = options
 
-    const fullUrl = `${baseUrl}${url}`
+    const fullUrl = `${baseUrl || ''}${url}`
 
     const reqHeaders = new Headers(headers)