Open
Conversation
tom-new
force-pushed
the
uf-anelasticity
branch
from
4697f7c to
81daabe
Compare
Signed-off-by: Sia Ghelichkhan <ghelichkhani.siavash@gmail.com>
sghelichkhani
requested changes
Apr 1, 2025
| """ | ||
| pass | ||
|
|
||
| def build_ghelichkhan_solidus(): |
Collaborator
There was a problem hiding this comment.
hmm ... I am not sure about having this in the package. The profile I used is basically combining two other profiles. So it's a bit misleading to call it a radial profile. The other problem is that those anelasticity parmaeters need to be agnostic about the solidus profile they are using. So this is also problematic!
Collaborator
There was a problem hiding this comment.
So I would say leave this out. This can be done still in the examples
| Args: | ||
| q_profile (str): The name of the parameter set to use (e.g. "Q1" for Q1). | ||
| """ | ||
| parameters = { |
Collaborator
There was a problem hiding this comment.
These parameters be in the class body, since these are hard-coded values belonging to the class.
Contributor
Author
|
Fixed docstrings: reopening to re-run tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CammaranoAnelasticityModelto have a class method constructor that allows specifying the QN model as a stringGoesAnelasticityModelanelasticity.py01_anelasticity_models.pyaccordingly