hw finished #2
Open
hw finished #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabyvon725
reviewed
Mar 15, 2018
| while(self.cap.isOpened): | ||
| ret, frame = self.cap.read() | ||
| if ret == False: | ||
| break |
Owner
There was a problem hiding this comment.
(建議) Line32 也可以寫成 if not ret: ，因為通常較少用 == 來比較物件跟 True/False boolean
gabyvon725
reviewed
Mar 15, 2018
| ret, frame = self.cap.read() | ||
| if ret == False: | ||
| break | ||
| frames.append(cv2.resize(frame, (512, 512))) |
Owner
There was a problem hiding this comment.
Line34 這邊希望使用的是 utils.py 裡的 resize()哦。可以看下 utils.py 的版本有對這份應用做一些特殊處理（擷取中心位置之後才 resize）所以跟直接 cv2.resize 結果可能有些出入
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.