tests: make Gemini callback coverage resilient to model deprecations#78
Open
shuofengzhang wants to merge 1 commit intogadievron:mainfrom
Open
tests: make Gemini callback coverage resilient to model deprecations#78shuofengzhang wants to merge 1 commit intogadievron:mainfrom
shuofengzhang wants to merge 1 commit intogadievron:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
GEMINI_TEST_MODELenv override (default:gemini-2.0-flash).GEMINI_TEST_MODELinstead of hardcodedgemini-2.0-flash-exp.GEMINI_TEST_MODELvalue for consistency.Why
gemini-2.0-flash-exp).GEMINI_API_KEYis set, this caused a deterministic false-negative test failure unrelated to callback behavior.Insight / Why this matters
GEMINI_API_KEYis absent, so many contributors never see the failure locally.Practical gain / Why this matters
Testing
scripts/clone_and_test.sh gadievron/raptor1 failed, 481 passed, 14 skipped(failure intest_gemini_callbackdue unavailable Gemini model name).pytest -q packages/llm_analysis/tests/test_llm_callbacks_providers.py1 passed, 4 skipped.scripts/clone_and_test.sh gadievron/raptor481 passed, 15 skipped.Risk analysis
packages/llm_analysis/tests/test_llm_callbacks_providers.py), with no runtime/application behavior changes.