Fix unit tests that was wrongly written and failed on Pester 5.5 (#435)

gaelcolas · Jun 30, 2023 · 73c8777 · 73c8777
1 parent e9155b8
commit 73c8777
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 80 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,8 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Fix unit tests that was wrongly written and failed on Pester 5.5.
+
 ## [0.116.5] - 2023-04-19
 
+### Fixed
+
 - Fix Azure Pipeline bug to resolve errors and delays during the build process. Shallow fetch has been disabled to ensure complete repository cloning. Fixes [#424](https://github.com/gaelcolas/Sampler/issues/424)
 
 ## [0.116.4] - 2023-04-06

diff --git a/.../Integration/PlasterTemplates/Sampler/CompleteSamplePlasterTemplate.Integration.Tests.ps1 b/.../Integration/PlasterTemplates/Sampler/CompleteSamplePlasterTemplate.Integration.Tests.ps1
@@ -112,10 +112,6 @@ Describe 'Complete Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'

diff --git a/tests/Integration/PlasterTemplates/Sampler/CustomModulePlasterTemplate.Integration.Tests.ps1 b/tests/Integration/PlasterTemplates/Sampler/CustomModulePlasterTemplate.Integration.Tests.ps1
@@ -113,10 +113,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -270,10 +266,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -428,10 +420,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -587,10 +575,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -677,10 +661,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -764,10 +744,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -854,10 +830,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -942,10 +914,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -1034,10 +1002,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -1123,10 +1087,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -1212,10 +1172,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -1303,10 +1259,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -1389,10 +1341,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -1477,10 +1425,6 @@ Describe 'Custom Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'

diff --git a/tests/Integration/PlasterTemplates/Sampler/DscCommunityPlasterTemplate.Integration.Tests.ps1 b/tests/Integration/PlasterTemplates/Sampler/DscCommunityPlasterTemplate.Integration.Tests.ps1
@@ -76,10 +76,6 @@ Describe 'DSC Community Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'

diff --git a/...gration/PlasterTemplates/Sampler/SimpleModuleNoBuildPlasterTemplate.Integration.Tests.ps1 b/...gration/PlasterTemplates/Sampler/SimpleModuleNoBuildPlasterTemplate.Integration.Tests.ps1
@@ -46,10 +46,6 @@ Describe 'Simple Module No Build Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath      = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'

diff --git a/tests/Integration/PlasterTemplates/Sampler/SimpleModulePlasterTemplate.Integration.Tests.ps1 b/tests/Integration/PlasterTemplates/Sampler/SimpleModulePlasterTemplate.Integration.Tests.ps1
@@ -61,10 +61,6 @@ Describe 'Simple Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -162,10 +158,6 @@ Describe 'Simple Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'
@@ -263,10 +255,6 @@ Describe 'Simple Module Plaster Template' {
             )
         }
 
-        AfterAll {
-            Remove-Item -Path $TestDrive -Recurse -Force
-        }
-
         It 'Should create a new module without throwing' {
             $invokePlasterParameters = @{
                 TemplatePath         = Join-Path -Path $importedModule.ModuleBase -ChildPath 'Templates/Sampler'