Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallelization for faster dependency download #462

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

johlju
Copy link
Collaborator

@johlju johlju commented Jan 28, 2024

Pull Request

Pull Request (PR) description

Changed

  • When resolving dependencies using PSResourceGet, it now uses parallelization
    to more quickly get the dependencies downloaded.

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju
Copy link
Collaborator Author

johlju commented Jan 28, 2024

I'm not certain of this change. It might conflict when downloading modules that uses the same dependent module. 🤔 Then two modules will try to write to the same folder... Not sure it is possible to prevent that.

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d47846) 81% compared to head (7d833b6) 81%.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #462   +/-   ##
===================================
  Coverage    81%    81%           
===================================
  Files        44     44           
  Lines      2328   2328           
===================================
  Hits       1904   1904           
  Misses      424    424           

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant