plugin: clean legacy socket installs#32
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c58c38c58
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name = entry.get("name") | ||
| if name not in KNOWN_SOCKET_PLUGINS: | ||
| return False |
There was a problem hiding this comment.
Narrow legacy entry detection to socket-specific paths
The cleanup predicate currently treats any local-source marketplace entry whose name matches a socket plugin as legacy, so --apply will delete valid non-legacy entries (for example, a user’s intentional local apple-dev-skills checkout used for development/fallback) just because it is local and name-matched. This makes the helper destructive outside the intended migration case; the match should also verify that the source path corresponds to known socket legacy locations before removing the entry.
Useful? React with 👍 / 👎.
Summary
Verification