Skip to content

plugin: clean legacy socket installs#32

Merged
gaelic-ghost merged 3 commits into
mainfrom
plugin/legacy-socket-install-cleanup
May 2, 2026
Merged

plugin: clean legacy socket installs#32
gaelic-ghost merged 3 commits into
mainfrom
plugin/legacy-socket-install-cleanup

Conversation

@gaelic-ghost
Copy link
Copy Markdown
Owner

Summary

  • add a dry-run-first helper for cleaning legacy socket copied-plugin installs
  • align the standalone apple-dev-skills marketplace name with its documented Git-backed install path
  • bump maintained socket plugin/version surfaces to 6.3.2

Verification

  • uv run scripts/validate_socket_metadata.py
  • uv run pytest
  • bash .github/scripts/validate_repo_docs.sh (from plugins/apple-dev-skills)
  • uv run ruff check scripts/cleanup_legacy_socket_installs.py tests/test_cleanup_legacy_socket_installs.py
  • uv run mypy scripts/cleanup_legacy_socket_installs.py tests/test_cleanup_legacy_socket_installs.py

@gaelic-ghost gaelic-ghost added the enhancement New feature or request label May 2, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c58c38c58

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +84 to +86
name = entry.get("name")
if name not in KNOWN_SOCKET_PLUGINS:
return False
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Narrow legacy entry detection to socket-specific paths

The cleanup predicate currently treats any local-source marketplace entry whose name matches a socket plugin as legacy, so --apply will delete valid non-legacy entries (for example, a user’s intentional local apple-dev-skills checkout used for development/fallback) just because it is local and name-matched. This makes the helper destructive outside the intended migration case; the match should also verify that the source path corresponds to known socket legacy locations before removing the entry.

Useful? React with 👍 / 👎.

@gaelic-ghost gaelic-ghost merged commit b4a9900 into main May 2, 2026
1 check passed
@gaelic-ghost gaelic-ghost deleted the plugin/legacy-socket-install-cleanup branch May 2, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant