Add guarded SPI add-package automation#40
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86ebc185fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| confirm_remote_semver_tag(identity, package_root, semver_tags) | ||
| checked_steps.append("remote semantic-version tag") | ||
|
|
||
| if indexed_state == "indexed": |
There was a problem hiding this comment.
run_readiness only rejects indexed_state == "indexed", but check_spi_index_state also returns non-authoritative values like unknown-network and unknown-http-* when SPI cannot be checked. In open/hands-free mode this still allows opening the Add Package form even though the duplicate-submission guard did not actually run (for example during SPI outages or transient HTTP failures), which defeats the script’s safety contract. Treat any state other than not-indexed as a hard failure unless --skip-index-check is explicitly requested.
Useful? React with 👍 / 👎.
1 participant
Summary
.spi.yml, live issue-template shape, and existing indexing state.packages.jsonedits,gh issue create, or manual label paths.gaelic-ghost/apple-dev-skillsand releasev6.4.1.Closes #39
Release
6.4.1Verification
uv run pytest testsuv run scripts/validate_socket_metadata.pyuv run ruff check scripts/spi_add_package.py tests/test_spi_add_package.py(cd plugins/apple-dev-skills && bash .github/scripts/validate_repo_docs.sh)(cd plugins/apple-dev-skills && uv run pytest)git diff --check