release: socket 6.5.0#43
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20dff3c507
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| marketplace_path = REPO_ROOT / ".agents" / "plugins" / "marketplace.json" | ||
| assert marketplace_path.is_file() | ||
|
|
||
| plugin_root = REPO_ROOT / "plugins" / "swiftasb-skills" | ||
| assert (plugin_root / ".codex-plugin" / "plugin.json").is_file() |
There was a problem hiding this comment.
Assert marketplace includes swiftasb-skills
These assertions only prove files exist in the checked-out repository, not that the socket marketplace you just added actually exposes swiftasb-skills to Codex. If .agents/plugins/marketplace.json drops or renames that plugin entry, codex plugin marketplace add can still succeed and this test will pass, so the intended install-surface regression is missed. Parse the marketplace JSON (or query the Codex plugin list under the temporary CODEX_HOME) and assert that swiftasb-skills is present.
Useful? React with 👍 / 👎.
Summary
Verification
Release