release: socket 6.6.0#45
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 407f426e3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| architecture_path = architecture_dir / "ARCHITECTURE.md" | ||
| slices_path = architecture_dir / "SLICES.md" | ||
| json_path = architecture_dir / "architecture.json" | ||
| write_text(architecture_path, render_architecture(model)) |
There was a problem hiding this comment.
Applying fixes currently rewrites ARCHITECTURE.md from the template on every run, which discards any repo-specific prose maintainers added (for example in Summary or Construction/Ownership). In apply workflows this causes repeatable data loss: a user can add valid manual architecture context, then lose it on the next run even when only generated inventories need refresh. The updater should patch only generated blocks (or merge with existing content) instead of replacing the full document.
Useful? React with 👍 / 👎.
| elif isinstance(dependency, dict): | ||
| dependencies.extend(str(value) for value in dependency.values() if isinstance(value, str)) |
There was a problem hiding this comment.
Dependency extraction only keeps dictionary values that are strings, but swift package dump-package commonly encodes target dependencies as objects like {"byName": ["DemoCore", null]}. In that case this code drops the dependency entirely, so generated target inventories and depends-on relationships are incomplete for normal Swift packages. This undermines the core architecture model accuracy and can hide real module coupling.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
Subtree accounting