-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make analysis buttons open workflow landing pages (#137) #138
feat: make analysis buttons open workflow landing pages (#137) #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool thank you!
app/utils/galaxy-api.ts
Outdated
import ky from "ky"; | ||
|
||
interface WorkflowLandingsBody { | ||
request_state: { reference_genome: string }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to vary across workflows, I suppose
request_state: { reference_genome: string }; | |
request_state: { [key: string]: string }: |
would be the right interface ?
app/utils/galaxy-api.ts
Outdated
}, | ||
}); | ||
const id = (await res.json()).uuid; | ||
return WORKFLOW_LANDING_URL_PREFIX + encodeURIComponent(id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return WORKFLOW_LANDING_URL_PREFIX + encodeURIComponent(id); | |
return `${WORKFLOW_LANDING_URL_PREFIX}${id}?public=true; |
UUIDs shouldn't need uri encoding, so I dropped that here, but of course no harm doing it anyway.
@mvdbeek Thanks for the feedback! I've:
|
@hunterckx, can you rebase this, please? Thanks! |
7e12980
to
67729d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're expecting the full TRS url here, which is the TRS id and the version.
Co-authored-by: Marius van den Beek <[email protected]>
For right now this is working well. I have a few things to build on here, could we get this merged ? |
No error handling for the API requestOnly regulation is set up