Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ena interface #359

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Ena interface #359

wants to merge 11 commits into from

Conversation

Smeds
Copy link
Collaborator

@Smeds Smeds commented Mar 6, 2025

Here's a first version of a viewer for ENA data:
view

There's still a bunch of improvements and formatting that can be done:

  • move component to "select data site" page
  • use databiosphere tables to display data instead
  • create nicer UI for Query build
    • improve look, make more modern, maybe everything on one row
    • use data from runReadFields.json to
      • show suggestion using field "description"
      • validate input using "type"
  • parameters that should be made configurable:
    • API url: http://127.0.0.1:3000/api/ena
    • number of allowed returned entries
    • return fields from run_reads:

should we have a search button to initiate search and validation instead of triggering on every input event?

@Smeds Smeds requested a review from NoopDog March 6, 2025 19:23
} from "app/apis/catalog/brc-analytics-catalog/common/entities";
import { NextResponse } from "next/server";

const items_limit = 10000;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max allowed items return, should maybe be configurable

setStatistics: React.Dispatch<React.SetStateAction<ReadRunStatistics>>
): Promise<{ status: number }> => {
try {
const response = await fetch(`http://127.0.0.1:3000/api/ena`, {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url to api should be configurable

@Smeds
Copy link
Collaborator Author

Smeds commented Mar 6, 2025

@NoopDog here's a first version of the view. If possible I would like to get some help to move it into the data selector page and also to get your input of how to make it more configurable. I will be away next week due to the kids having spring break.

@Smeds
Copy link
Collaborator Author

Smeds commented Mar 7, 2025

I can fix the stuff If I get some guidance of where to put stuff:

  • best config options
  • where to move the component
  • how to a table from databiosphere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant