Update default values for ACCP #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out we don't even need to differentiate between cloud providers given we're running on a basic VM so I think we can just remove that variable. |
nuwang
reviewed
Jan 31, 2025
| @@ -27,11 +8,13 @@ ingress: | |||
| hosts: | |||
| - host: ~ | |||
| paths: | |||
| - path: /galaxy | |||
| path: /galaxy | |||
| - path: / | |||
There was a problem hiding this comment.
Great to see all this simplification. Should the gcp.yml file be removed as well, since there's no cloud provider specific differentiation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the login values discussed in yesterday's meeting. Along the way, pull values into a separate file vs. having them cloud-dependent because the playbook is (largely) agnostic to cloud providers.
Tested this on AWS & GCP, both of which work as expected.