Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.2] Fail with error message when submitting invalid request #19489

Merged
merged 1 commit into from
Jan 30, 2025
Merged

[24.2] Fail with error message when submitting invalid request #19489

merged 1 commit into from
Jan 30, 2025

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jan 30, 2025

This should eventually be redundant / unnecessary with #17393 but in the meantime I think this can help anyone trying to use the API and cleans up the logs for admins. Fixes #19488

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Fail with error message when submitting invalid request
86b449b 
This should eventually be redundant / unnecessary with
galaxyproject#17393 but in the meantime I
think this can help anyone trying to use the API and cleans up the logs
for admins. Fixes galaxyproject#19488
@mvdbeek mvdbeek changed the title Fail with error message when submitting invalid request [24.2] Fail with error message when submitting invalid request Jan 30, 2025
@github-actions github-actions bot added this to the 25.0 milestone Jan 30, 2025
@mvdbeek mvdbeek requested a review from jmchilton January 30, 2025 15:09
@mvdbeek mvdbeek merged commit 5568073 into galaxyproject:release_24.2 Jan 30, 2025
53 of 56 checks passed
@mvdbeek mvdbeek mentioned this pull request Jan 31, 2025
Closed
@jdavcs jdavcs modified the milestones: 25.0, 24.2 Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

@jmchilton jmchilton Awaiting requested review from jmchilton

Assignees
No one assigned
Labels
area/API kind/bug
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mvdbeek @davelopez @jdavcs