[24.0] Fix deleting lddas in batch #19506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
force-pushed
the
24.0_fix_deleting_lddas_in_batch
branch
from
ae82fa4 to
995dff9
Compare
|
I've targeted 24.0 but should I target even older versions? |
Since this never worked, I think that's more than enough. |
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Feb 3, 2025
Pass hda id instead of dataset id to ``dataset_storage_info()``.
Fix the following traceback:
```
def test_storage_show(self, history_id):
hda = self.dataset_populator.new_dataset(history_id, wait=True)
hda_details = self.dataset_populator.get_history_dataset_details(history_id, dataset=hda)
dataset_id = hda_details["dataset_id"]
> storage_info_dict = self.dataset_populator.dataset_storage_info(dataset_id)
...
if http_error_msg:
> raise HTTPError(http_error_msg, response=self)
E requests.exceptions.HTTPError: 404 Client Error: Not Found for url: http://127.0.0.1:9129/api/datasets/9a58064fb2c43d99/storage
http_error_msg = ('404 Client Error: Not Found for url: '
'http://127.0.0.1:9129/api/datasets/9a58064fb2c43d99/storage')
reason = 'Not Found'
self = <Response [404]>
```
Broken since the test was introduced in commit c5bf63b .
Started failing after galaxyproject#19506 ,
but probably just because of database ids changing.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19490
How to test the changes?
License