Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Fix workflowID assignment in Markdown.vue #19507

Conversation

davelopez
Copy link
Contributor

Fixes #19503

this.markdownConfig might not have workflows.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.0 milestone Jan 31, 2025
To use undefined instead of an empty string and improve conditional checks
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mvdbeek mvdbeek merged commit 382aac5 into galaxyproject:release_24.2 Feb 1, 2025
25 of 27 checks passed
@davelopez davelopez deleted the 24.2_fix_type_issue_in_markdown_vue branch February 3, 2025 08:43
@jdavcs jdavcs modified the milestones: 25.0, 24.2 Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants