Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Fix error message when subworkflow input connection missing #19526

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Feb 3, 2025

Fixes #19511:

Screenshot 2025-02-03 at 11 02 51

There's more we can do:

  • Elevate disconnected required inputs to error in the best practice panel
  • Show the best practice panel unconditionally
  • Check for disconnected inputs on submission

I'll do some of these, but I think this would go beyond a simple bug fix

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.0 milestone Feb 3, 2025
@mvdbeek mvdbeek requested a review from a team February 3, 2025 17:06
@mvdbeek mvdbeek modified the milestones: 25.0, 24.2 Feb 4, 2025
@jdavcs jdavcs self-requested a review February 4, 2025 19:06
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

The failing test fails consistently on 24.2 (passed on 24.1 and dev), so it's not related to this PR.

@mvdbeek mvdbeek merged commit 0696805 into galaxyproject:release_24.2 Feb 5, 2025
50 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants