[24.0] Fix admin cancel job message not being displayed to the user #19537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19487
I'm not sure when this stopped working so I targeted
24.0
but all this code seems untouched for a long time 🤔It looked like the message should be set somehow in:
galaxy/lib/galaxy/managers/jobs.py
Line 288 in 062cdda
but this function does nothing in my testing, the actual dataset info seems to be set in
job.mark_deleted
so I moved it there with these changes. I hope this is the right fix.I will follow up with the feature request to optionally send notifications to the users in a new PR targeting
dev
.How to test the changes?
License