Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix admin cancel job message not being displayed to the user #19537

Merged

Conversation

davelopez
Copy link
Contributor

Fixes #19487

I'm not sure when this stopped working so I targeted 24.0 but all this code seems untouched for a long time 🤔

It looked like the message should be set somehow in:

self.app.job_manager.stop(job, message=message)

but this function does nothing in my testing, the actual dataset info seems to be set in job.mark_deleted so I moved it there with these changes. I hope this is the right fix.

I will follow up with the feature request to optionally send notifications to the users in a new PR targeting dev.

Before After
image image

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone Feb 4, 2025
@mvdbeek mvdbeek modified the milestones: 24.1, 24.2 Feb 4, 2025
@mvdbeek mvdbeek merged commit 929a833 into galaxyproject:release_24.0 Feb 4, 2025
43 of 53 checks passed
@davelopez davelopez deleted the 24.0_fix_delete_job_message_lost branch February 5, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants