Fix test_mulled_build.py::test_mulled_build_files_cli with use_mamba=True
#19545
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ba=True` Test `tests/tool_util/mulled/test_mulled_build.py::test_mulled_build_files_cli[True]`, where `[True]` refers to the parameter `use_mamba`, fails because if `conda install --quiet --yes 'mamba='` (the preinstall command) runs before `mamba install -p /usr/local`, then the latter expects either `/usr/local` not to exist or to be an existing environment. To work this around, create an environment in `/usr/local/env`, but still put it on the expected location `/usr/local` later.
nsoranzo
reviewed
Feb 5, 2025
With the aim of easing debugging, write one `run()` statement for the preinstall command, one to create the conda environment, another to install packages to the environment and one for the postinstall command.
This reverts commit bd24d0c. It makes sense to revert the changes because every `run()` statement runs in its own container, thus it cannot be ruled out that other code is building the preinstall or postinstall commands under the assumption that they will run in the same container (or even in the same container as the conda commands). An example is available on galaxyproject#19545 (comment).
nsoranzo
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick attempt at reducing the amount of failing tests, feel free to step in with a better solution.
Test
tests/tool_util/mulled/test_mulled_build.py::test_mulled_build_files_cli[True], where[True]refers to the parameteruse_mamba, fails because ifconda install --quiet --yes 'mamba='(the preinstall command) runs beforemamba install -p /usr/local, then the latter expects either/usr/localnot to exist or to be an existing environment.To work this around, create an environment in
/usr/local/env, but still put it on the expected location/usr/locallater.How to test the changes?
(Select all options that apply)
License