Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config options for tool dependency installs #19565

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

afgane
Copy link
Contributor

@afgane afgane commented Feb 6, 2025

Add three new configuration options to set/unset the tool dependency checkboxes when installing tools. In containerized deployments, such as the AnVIL, these options need to be set to false because containerized tools do not use external tool dependencies. Without this being configurable, we had to maintain a fork with these changes.

Screenshot 2025-02-06 at 3 38 03 PM

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

client/README.md Outdated Show resolved Hide resolved
@martenson
Copy link
Member

Seems like a fine solution to me -- it would be nice to clarify what exactly each of these options does.

Co-authored-by: Nuwan Goonasekera <[email protected]>
@afgane
Copy link
Contributor Author

afgane commented Feb 7, 2025

@martenson I agree but I don't know (this has been confusing terminology to me since the initial implementation). I'll see what I can find in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants