Add vue-tsc baseline comparison to client-lint workflow #19593
Merged
+42
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve error count extraction; add new test file for error reporting
…tsc, improving error count comparison logic
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our client linting workflow to run vue-tsc on both the PR branch and its target base branch. We extract the error counts from each run and compare them—failing the build only if the PR introduces additional type errors.
Just sorting them out all in one pass is intractable and disruptive per discussion in dev meeting. This way we can chip away at these incrementally without failing the build immediately, but also preventing more from creeping in.
How to test the changes?
(Select all options that apply)
License