Make getopts optional #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also update dependencies; explicit 2018 edition;
|
Nice! This'll let us keep getopts out of our dependency tree as well. I wouldn't bump the edition though, unless it's useful for code changes the only effect is to raise the MSRV. |
|
The only reason to set the edition is Cargo is emitting a warning for lack of edition field. I don't mind setting it back to 2015. |
zjp-CN
added a commit
to os-checker/os-checker
that referenced
this pull request
Nov 12, 2024
thechillday1
approved these changes
Jan 14, 2025
|
@gamache any news to include this patch?! |
eirnym
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly gates getopts as a default feature, so if jsonxf is used as a library, getopts won't be included in user's Cargo.lock.
Besides I explicitly set edition to 2021, update the Cargo.lock and fix the README.
But I bump the jsonxf version to v0.1.2, so would you mind making a release on crates.io?