fix(dxgi): stabilize FH4 factory hooks#1
Closed
FrontMage wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FH4 context
This addresses the FH4 crash path where system DXGI reached an indirect jump after our factory vtable clone only covered the public IDXGIFactory2 size. The patched clone now keeps additional readable slots while only replacing the public hook slots we own.
Verification
cmake --build build/cmakecmake --build build/windows-crossgit diff --check -- . ':(exclude)build'Notes
FH4 full buffer asset capture remains very slow because resource snapshots can write multiple GB during startup. That performance tuning is being handled separately from this hook stability fix.