feat: extend ruff checking and fix found issues

.gitignore

@@ -8,3 +8,4 @@ python_gammu.egg-info/
 .coverage
 /.cache/
 _codeql_detected_source_root
+/uv.lock

examples/addcontacts.py

@@ -26,7 +26,7 @@
 import gammu
 
 
-def main():
+def main() -> None:
     if len(sys.argv) != 3:
         print("This requires two parameters: memory_type and backup file (eg. vcard)!")
         sys.exit(1)

examples/addfile.py

@@ -22,18 +22,18 @@
 
 
 import os
+import pathlib
 import sys
 
 import gammu
 
 
-def main():
+def main() -> None:
     if len(sys.argv) != 3:
         print("This requires two parameters: file to upload and path!")
         sys.exit(1)
 
-    with open(sys.argv[1], "rb") as handle:
-        data = handle.read()
+    data = pathlib.Path(sys.argv[1]).read_bytes()
 
     state_machine = gammu.StateMachine()
     state_machine.ReadConfig()

examples/async.py

@@ -19,10 +19,10 @@
 # with this program; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 """
-python-gammu - Phone communication library
-Gammu asynchronous wrapper example with asyncio. This allows your application to care
-only about handling received data and not about phone communication
-details.
+Gammu asynchronous wrapper example with asyncio.
+
+This allows your application to care only about handling received data and not
+about phone communication details.
 """
 
 import asyncio
@@ -32,7 +32,7 @@
 import gammu.asyncworker
 
 
-async def send_message_async(state_machine, number, message):
+async def send_message_async(state_machine, number, message) -> None:
     smsinfo = {
         "Class": -1,
         "Unicode": False,
@@ -41,15 +41,15 @@ async def send_message_async(state_machine, number, message):
     # Encode messages
     encoded = gammu.EncodeSMS(smsinfo)
     # Send messages
-    for message in encoded:
+    for encoded_message in encoded:
         # Fill in numbers
-        message["SMSC"] = {"Location": 1}
-        message["Number"] = number
+        encoded_message["SMSC"] = {"Location": 1}
+        encoded_message["Number"] = number
         # Actually send the message
-        await state_machine.send_sms_async(message)
+        await state_machine.send_sms_async(encoded_message)
 
 
-async def get_network_info(worker):
+async def get_network_info(worker) -> None:
     info = await worker.get_network_info_async()
     print("NetworkName:", info["NetworkName"])
 
@@ -67,7 +67,7 @@ async def get_network_info(worker):
     print("  LAC:", info["LAC"])
 
 
-async def get_info(worker):
+async def get_info(worker) -> None:
     print("Phone information:")
     manufacturer = await worker.get_manufacturer_async()
     print("{:<15}: {}".format("Manufacturer", manufacturer))
@@ -79,11 +79,11 @@ async def get_info(worker):
     print("{:<15}: {}".format("Firmware", firmware[0]))
 
 
-async def main():
+async def main() -> None:
     gammu.SetDebugFile(sys.stderr)
     gammu.SetDebugLevel("textall")
 
-    config = dict(Device="/dev/ttyS6", Connection="at")
+    config = {"Device": "/dev/ttyS6", "Connection": "at"}
     worker = gammu.asyncworker.GammuAsyncWorker()
     worker.configure(config)
 
@@ -102,12 +102,12 @@ async def main():
             try:
                 signal = await worker.get_signal_quality_async()
                 print("Signal is at {:d}%".format(signal["SignalPercent"]))
-            except Exception as e:
+            except Exception as e:  # noqa: BLE001
                 print(f"Exception reading signal: {e}")
 
             await asyncio.sleep(10)
 
-    except Exception as e:
+    except Exception as e:  # noqa: BLE001
         print("Exception:")
         print(e)
 

examples/debugging.py

@@ -26,7 +26,7 @@
 import gammu
 
 
-def main():
+def main() -> None:
     # Global debug level
     gammu.SetDebugFile(sys.stderr)
     gammu.SetDebugLevel("textall")

examples/doc-exceptions.py

@@ -24,13 +24,13 @@
 import gammu.exception
 
 
-def main():
+def main() -> None:
     for exc in sorted(gammu.exception.__all__):
         print(f".. exception:: gammu.{exc}")
         print()
         doc = getattr(gammu.exception, exc).__doc__
-        for doc in doc.splitlines():
-            print(f"    {doc}")
+        for line in doc.splitlines():
+            print(f"    {line}")
         print()
 
 

examples/dummy_phone.py

@@ -20,16 +20,18 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #
 """
-python-gammu - Test script to test several Gammu operations
-(usually using dummy driver, but it depends on config)
+Dummy driver example.
+
+Test script to test several Gammu operations (usually using dummy driver, but
+it depends on config).
 """
 
 import sys
 
 import gammu
 
 
-def get_all_memory(state_machine, memory_type):
+def get_all_memory(state_machine, memory_type) -> None:
     status = state_machine.GetMemoryStatus(Type=memory_type)
 
     remain = status["Used"]
@@ -44,7 +46,7 @@ def get_all_memory(state_machine, memory_type):
             entry = state_machine.GetNextMemory(
                 Location=entry["Location"], Type=memory_type
             )
-        remain = remain - 1
+        remain -= 1
 
         print()
         print("{:<15}: {:d}".format("Location", entry["Location"]))
@@ -55,7 +57,7 @@ def get_all_memory(state_machine, memory_type):
                 print("{:<15}: {}".format(v["Type"], v["Value"]))
 
 
-def get_all_calendar(state_machine):
+def get_all_calendar(state_machine) -> None:
     status = state_machine.GetCalendarStatus()
 
     remain = status["Used"]
@@ -68,7 +70,7 @@ def get_all_calendar(state_machine):
             start = False
         else:
             entry = state_machine.GetNextCalendar(Location=entry["Location"])
-        remain = remain - 1
+        remain -= 1
 
         print()
         print("{:<20}: {:d}".format("Location", entry["Location"]))
@@ -77,7 +79,7 @@ def get_all_calendar(state_machine):
             print("{:<20}: {}".format(v["Type"], v["Value"]))
 
 
-def get_battery_status(state_machine):
+def get_battery_status(state_machine) -> None:
     status = state_machine.GetBatteryCharge()
 
     for x in status:
@@ -98,12 +100,12 @@ def get_all_sms(state_machine):
             start = False
         else:
             sms = state_machine.GetNextSMS(Location=sms[0]["Location"], Folder=0)
-        remain = remain - len(sms)
+        remain -= len(sms)
 
     return sms
 
 
-def print_sms_header(message, folders):
+def print_sms_header(message, folders) -> None:
     print()
     print("{:<15}: {}".format("Number", message["Number"]))
     print("{:<15}: {}".format("Date", message["DateTime"]))
@@ -119,16 +121,16 @@ def print_sms_header(message, folders):
     print("{:<15}: {}".format("Validity", message["SMSC"]["Validity"]))
 
 
-def print_all_sms(sms, folders):
+def print_all_sms(sms, folders) -> None:
     for m in sms:
         print_sms_header(m, folders)
         print("\n{}".format(m["Text"]))
 
 
-def link_all_sms(sms, folders):
+def link_all_sms(sms, folders) -> None:
     data = gammu.LinkSMS([[msg] for msg in sms])
 
-    for x in data:
+    for x in data:  # noqa: PLR1702
         v = gammu.DecodeSMS(x)
 
         m = x[0]
@@ -155,7 +157,7 @@ def link_all_sms(sms, folders):
                     print()
 
 
-def get_all_todo(state_machine):
+def get_all_todo(state_machine) -> None:
     status = state_machine.GetToDoStatus()
 
     remain = status["Used"]
@@ -168,7 +170,7 @@ def get_all_todo(state_machine):
             start = False
         else:
             entry = state_machine.GetNextToDo(Location=entry["Location"])
-        remain = remain - 1
+        remain -= 1
 
         print()
         print("{:<15}: {:d}".format("Location", entry["Location"]))
@@ -191,7 +193,7 @@ def get_set_date_time(state_machine):
     return dt
 
 
-def main():
+def main() -> None:
     if len(sys.argv) != 2:
         print("This requires one parameter with location of config file!")
         sys.exit(1)

examples/filesystem_test.py

@@ -20,9 +20,11 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #
 """
+Filesystem testing.
+
 This file should provide me with a test frame for the filesystem
 functions. It can't be run automatically, but you should be able
-to decide, whether the output looks sensible
+to decide, whether the output looks sensible.
 
 BEWARE - the test WILL TOUCH AND WRITE FILESYSTEM!!
 
@@ -51,7 +53,7 @@
 import gammu
 
 
-def main():
+def main() -> None:  # noqa: PLR0912, PLR0915, C901
     parser = argparse.ArgumentParser(usage="usage: %(prog)s [options]")
 
     parser.add_argument(
@@ -182,13 +184,13 @@ def main():
         else:
             attribute = ""
             if file_f["Protected"]:
-                attribute = attribute + "P"
+                attribute += "P"
             if file_f["ReadOnly"]:
-                attribute = attribute + "R"
+                attribute += "R"
             if file_f["Hidden"]:
-                attribute = attribute + "H"
+                attribute += "H"
             if file_f["System"]:
-                attribute = attribute + "S"
+                attribute += "S"
             print(
                 "ID:         "
                 + file_f["ID_FullName"]
@@ -234,13 +236,13 @@ def main():
         else:
             attribute = ""
             if file_f["Protected"]:
-                attribute = attribute + "P"
+                attribute += "P"
             if file_f["ReadOnly"]:
-                attribute = attribute + "R"
+                attribute += "R"
             if file_f["Hidden"]:
-                attribute = attribute + "H"
+                attribute += "H"
             if file_f["System"]:
-                attribute = attribute + "S"
+                attribute += "S"
             print(
                 "ID:         "
                 + file_f["ID_FullName"]
@@ -290,13 +292,13 @@ def main():
         else:
             attribute = ""
             if file_f["Protected"]:
-                attribute = attribute + "P"
+                attribute += "P"
             if file_f["ReadOnly"]:
-                attribute = attribute + "R"
+                attribute += "R"
             if file_f["Hidden"]:
-                attribute = attribute + "H"
+                attribute += "H"
             if file_f["System"]:
-                attribute = attribute + "S"
+                attribute += "S"
             print(
                 "ID:         "
                 + file_f["ID_FullName"]

examples/getallcalendar.py

@@ -19,7 +19,7 @@
 # with this program; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #
-"""Example for reading calendar from phone"""
+"""Example for reading calendar from phone."""
 
 import gammu
 
@@ -46,7 +46,7 @@
         start = False
     else:
         entry = state_machine.GetNextCalendar(Location=entry["Location"])
-    remain = remain - 1
+    remain -= 1
 
     # Display it
     print()

examples/getallmemory.py

@@ -26,7 +26,7 @@
 import gammu
 
 
-def main():
+def main() -> None:
     state_machine = gammu.StateMachine()
     state_machine.ReadConfig()
     state_machine.Init()
@@ -51,7 +51,7 @@ def main():
             entry = state_machine.GetNextMemory(
                 Location=entry["Location"], Type=memory_type
             )
-        remain = remain - 1
+        remain -= 1
 
         print()
         print("{:<15}: {:d}".format("Location", entry["Location"]))