Skip to content

Potential fix for 1 code quality finding #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nijel merged 2 commits into from
Feb 5, 2026
Merged

Potential fix for 1 code quality finding #199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b795281
Apply suggested fix to test/test_smsd.py from Copilot Autofix
nijel Feb 5, 2026
5b1e92c
Apply suggestion from @nijel
nijel Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/test_smsd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"SMSC": {"Location": 1},
"Number": "1234567890",
}
MAX_STATUS_RETRIES = 2


def get_script():
Expand Down Expand Up @@ -126,7 +127,7 @@ def test_smsd(self) -> None:

# Show SMSD status
retries = 0
while retries < 2:
while retries < MAX_STATUS_RETRIES:
status = smsd.GetStatus()
if status["Sent"] >= 2:
break
Expand Down
Loading