Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'maxTime' argument #51

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add 'maxTime' argument #51

merged 1 commit into from
Aug 30, 2024

Conversation

ChrisJefferson
Copy link
Member

Add 'maxTime' argument.

Fixes #50 , and based on a patch in that issue, updated for current git head

@fingolfin fingolfin closed this Mar 23, 2024
@fingolfin fingolfin reopened this Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Merging #51 (bbc55ab) into master (4c76756) will decrease coverage by 1.0%.
The diff coverage is 84.6%.

❗ Current head bbc55ab differs from pull request most recent head 1974803. Consider uploading reports for the commit 1974803 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #51     +/-   ##
========================================
- Coverage    95.1%   94.1%   -1.0%     
========================================
  Files           3       3             
  Lines         144     154     +10     
  Branches       14      15      +1     
========================================
+ Hits          137     145      +8     
- Misses          3       4      +1     
- Partials        4       5      +1     
Files Coverage Δ
gap/curl.gd 100.0% <ø> (ø)
gap/curl.gi 100.0% <100.0%> (ø)
src/curl.c 91.1% <50.0%> (-1.8%) ⬇️

@fingolfin fingolfin closed this Mar 24, 2024
@fingolfin fingolfin reopened this Mar 24, 2024
@ChrisJefferson
Copy link
Member Author

Just rebased this, added another test (realised there was only tests that check for failure, none that check for success!) I did also check the timeout works and stops, but it's hard to test that because on fast internet, it's hard to set a small enough timeout it definately times out.

@fingolfin fingolfin merged commit cd3dd91 into master Aug 30, 2024
8 checks passed
@fingolfin fingolfin deleted the options branch August 30, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasionally post requests to the Bilbao crystallographic server hang indefinitely
2 participants