fix: de-duplicate skill quality rules and resolver overlap#142
Open
24601 wants to merge 2 commits intogarrytan:masterfrom
Open
fix: de-duplicate skill quality rules and resolver overlap#14224601 wants to merge 2 commits intogarrytan:masterfrom
24601 wants to merge 2 commits intogarrytan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/conventions/quality.mdinstead of repeating the same citation/back-link/notability guidance across multiple skillsmaintainandcitation-fixer"citation audit"trigger frommaintainsocitation-fixerowns that phrase cleanlyWhy this change
gbrain doctor --jsonwas reporting resolver/DRY warnings in the skill layer even though runtime health was otherwise fine.Before this patch:
maintainandcitation-fixerAfter this patch:
gbrain doctor --json: healthyThis keeps the skill layer closer to the architecture the repo already wants:
skills/conventions/quality.mdcheckResolvable()/gbrain doctorScope
This is intentionally narrow.
No runtime command behavior changed.
No engine/schema/search logic changed.
No version bump or changelog entry included.
The only behavior-level change is trigger ownership:
citation-fixerkeeps"citation audit"maintainremains the broader health sweep skillFiles changed
skills/RESOLVER.mdskills/ingest/SKILL.mdskills/enrich/SKILL.mdskills/setup/SKILL.mdskills/signal-detector/SKILL.mdskills/idea-ingest/SKILL.mdskills/media-ingest/SKILL.mdskills/meeting-ingestion/SKILL.mdskills/maintain/SKILL.mdVerification
bun test test/resolver.test.ts test/skills-conformance.test.ts bun run src/cli.ts doctor --jsonObserved results:
gbrain doctor --json: healthyokNotes
I kept this as a hygiene-only patch rather than bundling it into a larger docs/skills wave so it is easy to review, merge, or reapply.