fix: engines.bun floor must match the CI pin, and a test that says so - #2815
Open
chongwon83 wants to merge 1 commit into
Open
fix: engines.bun floor must match the CI pin, and a test that says so#2815chongwon83 wants to merge 1 commit into
chongwon83 wants to merge 1 commit into
Conversation
`engines.bun` is `>=1.0.0` while every CI surface pins `1.3.13` — a nine-minor
gap that nothing enforces. `bun-version-drift.test.ts` already keeps the CI
surfaces in lockstep, but it says nothing about the version a contributor
actually runs, so the gap is invisible until the suite goes red for reasons
that look like repo bugs.
That is not hypothetical. On bun 1.2.20 (below the floor, but allowed by
`>=1.0.0`):
- `gen-skill-docs > every generated SKILL.md frontmatter parses as strict YAML`
and its Codex twin threw `undefined is not an object (evaluating
'Bun.YAML.parse')`. `Bun.YAML` landed in bun 1.2.21, one patch above the
installed version.
- `browse/test/commands.test.ts`, `parity-suite`, and `openclaw-native-skills`
failed 54-56 tests, and the count moved between runs on an unchanged tree —
which reads as flake.
Both were diagnosed as repo defects, twice, before anyone compared the local
bun to the CI pin. A single `bun upgrade` cleared all of them.
Changes:
- `package.json`: `engines.bun` `>=1.0.0` → `>=1.3.13`, matching the pin.
- `test/bun-version-drift.test.ts`: new assertion that the `engines.bun` floor
equals the CI pin. It cannot join the existing all-equal check because
`engines` is a range, so it derives the pin from `collectPins()` and compares
against `>=${pin}`. This keeps the file's stated contract — "Bumping Bun:
change every surface in one commit; this test names each one" — true of
`engines` as well, so the next bump cannot silently leave the floor behind.
Verified both arms: the new test fails with
`engines.bun must state the CI bun as its floor (CI pins 1.3.13)` when the
floor is reverted to `>=1.0.0`, and passes at `>=1.3.13`.
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
engines.bunis>=1.0.0while every CI surface pins1.3.13— a nine-minorgap that nothing enforces.
bun-version-drift.test.tsalready keeps the CIsurfaces in lockstep, but it says nothing about the version a contributor
actually runs, so the gap is invisible until the suite goes red for reasons
that look like repo bugs.
That is not hypothetical. On bun 1.2.20 (below the floor, but allowed by
>=1.0.0):gen-skill-docs > every generated SKILL.md frontmatter parses as strict YAMLand its Codex twin threw
undefined is not an object (evaluating 'Bun.YAML.parse').Bun.YAMLlanded in bun 1.2.21, one patch above theinstalled version.
browse/test/commands.test.ts,parity-suite, andopenclaw-native-skillsfailed 54-56 tests, and the count moved between runs on an unchanged tree —
which reads as flake.
Both were diagnosed as repo defects, twice, before anyone compared the local
bun to the CI pin. A single
bun upgradecleared all of them.Changes:
package.json:engines.bun>=1.0.0→>=1.3.13, matching the pin.test/bun-version-drift.test.ts: new assertion that theengines.bunfloorequals the CI pin. It cannot join the existing all-equal check because
enginesis a range, so it derives the pin fromcollectPins()and comparesagainst
>=${pin}. This keeps the file's stated contract — "Bumping Bun:change every surface in one commit; this test names each one" — true of
enginesas well, so the next bump cannot silently leave the floor behind.Verified both arms: the new test fails with
engines.bun must state the CI bun as its floor (CI pins 1.3.13)when thefloor is reverted to
>=1.0.0, and passes at>=1.3.13.