JsonWebToken.Algorithm.Hmac: Use :crypto.mac (OTP24) #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanodan
changed the title
|
@garyf Would be nice to have this PR merge so the library is supported for OPT24 |
oivoodoo
reviewed
Jun 17, 2021
| def sign(sha_bits, shared_key, signing_input) do | ||
| validate_params(sha_bits, shared_key) | ||
| :crypto.hmac(sha_bits, shared_key, signing_input) | ||
| :crypto.mac(:hmac, sha_bits, shared_key, signing_input) |
There was a problem hiding this comment.
Hi @lanodan
what about to have the code like that:
if Code.ensure_loaded?(:crypto) and function_exported?(:crypto, :mac, 4) do
defp hmac(type, key, data), do: :crypto.mac(:hmac, type, key, data)
else
defp hmac(type, key, data), do: :crypto.hmac(type, key, data)
endand then just call:
hmac(sha_bits, shared_key, signing_input)https://github.com/elixir-ecto/postgrex/blob/master/lib/postgrex/scram.ex#L69
and it's definitely would be great to merge it as soon as possible. but it looks like the library has no active support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes tests on OTP24.