Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bartoc config #70

Merged
merged 2 commits into from
Mar 21, 2025
Merged

New bartoc config #70

merged 2 commits into from
Mar 21, 2025

Conversation

MontyBitto
Copy link

It still keeps the default logo and favicon. Schemes load, but there's still problems.

@rodolv-commons
Copy link
Member

Hi @MontyBitto and thanks for the contribution!
First thing I think it is better to change the destination branch of this pull request to dev. Next I will put some comments in your commit

@rodolv-commons rodolv-commons self-requested a review March 21, 2025 12:29
@rodolv-commons rodolv-commons changed the base branch from main to dev March 21, 2025 14:38
@rodolv-commons rodolv-commons merged commit a338bcc into gbv:dev Mar 21, 2025
2 checks passed
@rodolv-commons
Copy link
Member

Sorry @MontyBitto I closed this PR by accident. Will open a new one, your code is merged in dev branch.

@rodolv-commons
Copy link
Member

branch is https://github.com/gbv/jskos-proxy/tree/Issue-%2370-bartoc-config, can you work with that branch? I mean pulling and pushing changes?

@MontyBitto
Copy link
Author

Yes, I can work on that branch. Thank you.

@rodolv-commons
Copy link
Member

super, problem about favicon was about the cache of the browser, as you discovered Chrome worked and if you open a private incognito window locally with the app running, you should get the favicon also in firefox. However I resized the favicon to be 16x16 foe better compatibility.
Now problem with the logo, I am working on. Feel free to push your changes to this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants