Add CRC Operation #1993
Merged
Add CRC Operation #1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…C's. Old Operations (CRC8, CRC16 and CRC32) and their dependencies are removed
…C's. Old Operations (CRC8, CRC16 and CRC32) and their dependencies are removed
|
I have included CRC-16/A and CRC-16/B without libraries in this pull request so part of #9 would be done |
|
I'm done. Sorry for multi commit |
|
Woah, this seems awesome! One fewer dependency and so many validity checks. Thanks so much for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I saw that the CRC calculation was divided into 3 operations (CRC8, CRC16 and CRC32) so I have combined them into a single native operation and deleted the previous ones and their dependencies. In addition, I have added all CRCs known up.
I hope it can be incorporated into the main branch.
Thank you very much for this magnificent tool, greetings