fix: KernelThinning partitioning. #1088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test to verify that `kt_half_recursive` behaves as expected. Previously, `kt_half_recursive` would return a list of identical coresets, rather than a recursive split. refs: #1086
Contributor
The jit variant is applied to the cached and uncached reduce calls. This more accurately captures expected invariant.
Contributor
Contributor
Performance reviewCommit
|
gchqdev227
requested changes
Nov 21, 2025
Member
gchqdev227
left a comment
gchqdev227
left a comment
There was a problem hiding this comment.
The tests look good, and the code changes definitely address the issue.
I've highlighted a line of code I don't think is tested in the changes. It's not a particularly complex case, but I could image it being refactored down the line in a way that undoes the improvements here?
Contributor
gchqdev227
reviewed
Nov 21, 2025
gchqdev227
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
Closes #1086
How Has This Been Tested?
Adds a test to verify that
kt_half_recursivebehaves as expected. Previously,kt_half_recursivewould return a list of identical coresets, rather than a recursive split.Does this PR introduce a breaking change?
No.
Checklist before requesting a review