-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test with gtest #676
Add test with gtest #676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a reasonable test!
Once the tests start passing, of course. We'd have to either install gtest in the Github CI runner and on developer machines, or skip the new tests outside of Docker (see the GCOVR_ISOLATED_TEST
token that's set in the Dockerfile and used in test_args.py
)
Use a shallow clone. Co-authored-by: Lukas Atkinson <[email protected]>
The test fails because the DTD for cobertura wasn't available. I'll update the test to use a copy of the DTD.
|
I searched for a solution but missed |
At least on Linux, can query for the existence of a library with a suitable version like pkg-config --atleast-version=1.12.0 gtest |
Since there is no command for Windows I'll rely on |
Codecov ReportBase: 94.78% // Head: 95.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #676 +/- ##
==========================================
+ Coverage 94.78% 95.22% +0.43%
==========================================
Files 24 24
Lines 3452 3495 +43
Branches 662 615 -47
==========================================
+ Hits 3272 3328 +56
+ Misses 99 94 -5
+ Partials 81 73 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Refactor existing usage of GCOVR_ISOLATED_TEST.
8d8aa35
to
eea0fa7
Compare
This PR modifies the existing CMake tests to use the
-DCMAKE_BUILD_TYPE=PROFILE
as described in the docs.In addition a new test is added which use the gtest library from the docker container.