Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore tabindex="-1" #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ignore tabindex="-1" #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d86e39f
Don't focus things that aren't tabindexed
citelao May 22, 2015
0c4ffab
If you don't have time to do it right...
citelao May 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modal-window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
*/

// jQuery formatted selector to search for focusable items
var focusableElementsString = "a[href], area[href], input:not([disabled]), select:not([disabled]), textarea:not([disabled]), button:not([disabled]), iframe, object, embed, *[tabindex], *[contenteditable]";
var focusableElementsString = "a[href], area[href], input:not([disabled]), select:not([disabled]), textarea:not([disabled]), button:not([disabled]), iframe, object, embed, *[tabindex]:not([tabindex='-1']), *[contenteditable]";

// store the item that has focus before opening the modal window
var focusedElementBeforeModal;
Expand Down Expand Up @@ -184,4 +184,4 @@ function hideModal() {

// set focus back to element that had it before the modal was opened
focusedElementBeforeModal.focus();
}
}