feat(frontend): switch auth screens to challenge-based wallet login#398
Closed
quickweb-stack wants to merge 2 commits into
Closed
feat(frontend): switch auth screens to challenge-based wallet login#398quickweb-stack wants to merge 2 commits into
quickweb-stack wants to merge 2 commits into
Conversation
This comment was marked as spam.
This comment was marked as spam.
Contributor
|
I can't merge this pr if you don't let CI run. |
Contributor
|
I'm blocking and reporting your account |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #397
Pull Request Template
Description
Summary of Changes
Okay, I found one issue in the codebase: the register/page.tsx had a 'use server' directive at the top, which was incorrect because the page renders , which is a client component ( 'use client' ).
File Modified: app/app/(auth)/register/page.tsx
The existing authentication flow in wallet-login-form.tsx already uses the modern SEP-10 challenge and verify endpoints as intended! Here's the flow:
The legacy auth endpoints ( legacy-login , legacy-register ) aren't used in the UI anymore, which aligns with the user's request!
Checklist
npx prisma generateafter schema changesnpx prisma migrate devornpx prisma migrate deployas appropriatePost-Merge Steps for Maintainers
If this PR includes changes to the Prisma schema:
Run the following command to apply the migration to your database:
or, for local development:
Ensure your CI pipeline runs the migration before tests (add this step if missing):
Make sure the database user in CI has permission to run migrations.
If you have any questions, please comment on this PR.