Bump dependencies: knip, @types/node, bn.js#102
Conversation
- knip 5.84.1 → 5.85.0 - @types/node 25.2.3 → 25.3.0 - bn.js 5.2.2 → 5.2.3 (root + packages/swapper)
Changed Files
|
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs routine dependency updates for several key packages: Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request consolidates dependency updates for knip, @types/node, and bn.js. The changes are mostly standard version bumps. However, the lockfile reveals a significant version fragmentation for @types/node, where some sub-dependencies (like @types/ws@7.4.7) have downgraded from version 25 to 12. This can lead to TypeScript compilation errors such as 'Duplicate identifier' or missing definitions for newer Node.js APIs. I recommend using pnpm.overrides in the root package.json to enforce a consistent version of Node.js types across the entire workspace.
Summary
Consolidates 4 Dependabot PRs into a single update:
Test plan
pnpm buildpassespnpm testpasses (79 passed, 13 skipped)Closes #97, closes #98, closes #99, closes #101